Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return a list instead of None in RelationalBone.relskels_from_keys #1334

Merged

Conversation

ArneGudermann
Copy link
Contributor

Fix the Bug that this fails when

rel_list = self.relskels_from_keys(parsed_value)
if append:
if language:
skel[boneName][language].extend(rel_list)
else:
if not isinstance(skel[boneName], list):
skel[boneName] = []
skel[boneName].extend(rel_list)

this returns None
if not all(db_objs := db.Get([db.keyHelper(value[0], self.kind) for value in key_rel_list])):
return None

@ArneGudermann ArneGudermann added bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Nov 26, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone Nov 26, 2024
Copy link
Member

@sveneberth sveneberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phorward phorward changed the title fix: Return a list instead of None in relskels_from_keys fix: Return a list instead of None in RelationalBone.relskels_from_keys Nov 26, 2024
@phorward phorward merged commit 2e313a8 into viur-framework:main Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants