-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make SkeletonInstance json serializable #1262
Merged
phorward
merged 7 commits into
viur-framework:develop
from
ArneGudermann:feat/json_SkeletonInstance
Sep 23, 2024
Merged
feat: Make SkeletonInstance json serializable #1262
phorward
merged 7 commits into
viur-framework:develop
from
ArneGudermann:feat/json_SkeletonInstance
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneGudermann
added
feature
New feature or request
Priority: Medium
This issue may be useful, and needs some attention.
labels
Sep 20, 2024
phorward
requested changes
Sep 20, 2024
Co-authored-by: Jan Max Meyer <jmm@phorward.de>
phorward
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify the code-snippets in the comments in the source code.
phorward
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #1092 and makes SkeletonInstances now json serializable.
Like:
Now get in json render