feat: FileBone(public=True) for public files
#1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phorward
changed the title
FileBone(public=True) for public files without signature authentication
phorward
changed the title
FileBone(public=True) for public files without signature authenticationFileBone(public=True) for public files
phorward
requested changes
Aug 27, 2024
There was a problem hiding this comment.
@akelch can you test this branch again with my refactoring?
@sveneberth @ArneGudermann looking phorward for your review!
akelch
commented
Aug 28, 2024
akelch
commented
Aug 28, 2024
akelch
commented
Aug 28, 2024
sveneberth
requested changes
Sep 13, 2024
Co-authored-by: Sven Eberth <se@mausbrand.de>
ArneGudermann
previously approved these changes
Sep 23, 2024
phorward
added
Priority: High
phorward
dismissed stale reviews from ArneGudermann and themself
via
a94b922
phorward
approved these changes
Sep 23, 2024
phorward
added a commit
that referenced
this pull request
Sep 23, 2024
phorward
added a commit
to phorward/viur-core
that referenced
this pull request
Sep 24, 2024
This is a follow-up on viur-framework#1241
phorward
added a commit
that referenced
this pull request
Sep 30, 2024
This is a follow-up on #1241 --------- Co-authored-by: Sven Eberth <mail@sveneberth.de>
phorward
added a commit
to phorward/viur-core
that referenced
this pull request
Dec 11, 2024
…ork#1344 Added required `RecordBone.refresh` for Fluidpages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds public files. Public files are stored in an extra bucket that follows this name: public-dot-{__PROJECT_ID}
The bucket must be created with ACL rights.
With getUploadUrl, the parameter public is used to decide whether it is a public file or not.
Filebones with flag public=True can only refer to a public file
Public files again deliver a servingurl.