Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move datastore index retrieval to SkelModule #1231

Merged

Conversation

phorward
Copy link
Member

@phorward phorward commented Aug 8, 2024

This is also a better implementation, as the previous checked for module name, but the kind name is the important one!

This is also a better implementation, as the previous checked for module name, but the kind name is the important one!
@phorward phorward added bug(fix) Something isn't working or address a specific issue or vulnerability refactoring Pull requests that refactor code but do not change its behavior. labels Aug 8, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Aug 8, 2024
@phorward phorward merged commit 4e7b3bb into viur-framework:develop Aug 12, 2024
3 checks passed
phorward added a commit that referenced this pull request Aug 20, 2024
This is a back port of #1231 to core-3.6, as #1232 should become part of
v3.6.

This is also a better implementation, as the previous checked for module
name, but the kind name is the important one!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability refactoring Pull requests that refactor code but do not change its behavior.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants