Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MultipleConstraints as intended #1228

Merged
merged 6 commits into from
Aug 18, 2024

Conversation

phorward
Copy link
Member

@phorward phorward commented Aug 5, 2024

Fixes MultipleConstraints

  • requirement for a hashed tuple
  • renamed dataclass members*
  • required modularization for RelationalBone and RecordBone

*) yes, this is a breaking change, BUT this feature isn't used in any ViUR project so far, I'm sure.

Fixes `MultipleConstraints`

- requirement for a hashed tuple
- renamed dataclass members*

*) yes, this is a breaking change, BUT this feature isn't used in any ViUR project so far, I'm sure.
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
src/viur/core/bones/base.py Outdated Show resolved Hide resolved
@phorward phorward added bug(fix) Something isn't working or address a specific issue or vulnerability refactoring Pull requests that refactor code but do not change its behavior. labels Aug 8, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Aug 8, 2024
@phorward phorward requested a review from sveneberth August 9, 2024 10:48
@phorward phorward added the viur-meeting Issues to discuss in the next ViUR meeting label Aug 12, 2024
@phorward phorward merged commit e2e6ce6 into viur-framework:main Aug 18, 2024
4 checks passed
@phorward phorward deleted the fix-MultipleConstraints branch August 18, 2024 21:29
@phorward phorward removed the viur-meeting Issues to discuss in the next ViUR meeting label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability refactoring Pull requests that refactor code but do not change its behavior.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants