feat: Retrieve default descr from bone's name in its Skeleton
#1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows to define a bone ```py test = StringBone() ``` which is shown as "test" bone, instead of just an empty string.
phorward
changed the title
descr from bone's namedescr from bone's name in its Skeleton
sveneberth
requested changes
Aug 6, 2024
Co-authored-by: Sven Eberth <mail@sveneberth.de>
sveneberth
requested changes
Aug 6, 2024
…ject and keep the descr change-/setable (if necessary and if the bone is cloned)
sveneberth
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Creating every time u access .descr a translate instance is not really efficient.
I have another solution: phorward#7
The translate object in the structure is btw no problem and needs to extra str-cast since we use our own CustomJsonEncoder.
feat: Use `setSystemInitialized` to create only once a `translate` object
It's kinda over-engineered, but we can make it so. |
sveneberth
approved these changes
Aug 9, 2024
phorward
added
feature
phorward
added a commit
to phorward/viur-core
that referenced
this pull request
Aug 26, 2024
This is a regression introduced by viur-framework#1227 causing descr() is called before a session is available.
phorward
added a commit
that referenced
this pull request
Aug 27, 2024
phorward
added a commit
that referenced
this pull request
Nov 19, 2024
This bug is a regression of #1277 and #1227. The `__system_initialized`-bool should be set *after* all setSystemInitialized() functions where invoked, as the system is defined to be initialized *after* the stuff where worked. Otherwise, `SpamBone.descr` cannot determine whether it is executed in an uninitialized or initialized system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to define a bone
which is shown as "test" bone, instead of just an empty string.