Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Session.__delitem__ causes endless recursion #1208

Merged
merged 1 commit into from
Jul 10, 2024
Merged

fix: Session.__delitem__ causes endless recursion #1208

merged 1 commit into from
Jul 10, 2024

Conversation

phorward
Copy link
Member

Fixes an endless recursion, this part of the new session was not tested before.

@phorward phorward mentioned this pull request Jul 10, 2024
Merged
@phorward phorward added the bug(fix) Something isn't working or address a specific issue or vulnerability label Jul 10, 2024
@phorward phorward added this to the ViUR-core v3.7 milestone Jul 10, 2024
@phorward phorward merged commit d50e8f2 into viur-framework:develop Jul 10, 2024
3 checks passed
@phorward phorward deleted the fix-Session.__delitem__ branch July 10, 2024 13:57
@phorward phorward mentioned this pull request Jul 11, 2024
Closed
phorward added a commit that referenced this pull request Jul 15, 2024
@phorward @sveneberth
feat: Add SpamBone (#1209)
6f3a680 
Adds a simple math question as spam protection, that works without any
third-party products.
We got a fine experience with this yet in several projects.

Requires #1208 to be fixed.

---------

Co-authored-by: Sven Eberth <mail@sveneberth.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveneberth sveneberth sveneberth approved these changes

@ArneGudermann ArneGudermann Awaiting requested review from ArneGudermann

@KadirBalku KadirBalku Awaiting requested review from KadirBalku

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@phorward @sveneberth