Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skel.update and skel.__ior__ #1103

Merged
merged 7 commits into from
Jun 10, 2024
Merged

feat: add skel.update and skel.__ior__ #1103

merged 7 commits into from
Jun 10, 2024

Conversation

ArneGudermann
Copy link
Contributor

resolves #1098

@ArneGudermann ArneGudermann added the Priority: Low This issue can be considered with enough idle time. label Mar 15, 2024
@ArneGudermann ArneGudermann added this to the ViUR-core v3.7 milestone Mar 15, 2024
@ArneGudermann ArneGudermann changed the title Feat/skel update feat: add skel.update and skel.__or__ Mar 15, 2024
sveneberth
sveneberth requested changes Mar 15, 2024
View reviewed changes
src/viur/core/skeleton.py Outdated Show resolved Hide resolved
src/viur/core/skeleton.py Outdated Show resolved Hide resolved
src/viur/core/skeleton.py Outdated Show resolved Hide resolved
src/viur/core/skeleton.py Outdated Show resolved Hide resolved
@ArneGudermann @sveneberth
Apply suggestions from code review
85c131a 
Co-authored-by: Sven Eberth <mail@sveneberth.de>
@ArneGudermann ArneGudermann changed the title feat: add skel.update and skel.__or__ feat: add skel.update and skel.__ior__ Mar 18, 2024
sveneberth
sveneberth requested changes Mar 19, 2024
View reviewed changes
src/viur/core/skeleton.py Outdated Show resolved Hide resolved
@sveneberth sveneberth linked an issue Mar 23, 2024 that may be closed by this pull request
Implement .update(dict_values) on Skeleton/SkeletonInstance #1098
Closed
@phorward
Copy link
Member

Same as #1147, Skeleton could be inherited from dict or db.Enitity to provide all dict features. What do you think? @ArneGudermann @sveneberth

@ArneGudermann ArneGudermann requested a review from sveneberth May 24, 2024 10:10
@phorward phorward merged commit f7ff99f into viur-framework:develop Jun 10, 2024
3 checks passed
@ArneGudermann ArneGudermann mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phorward phorward phorward approved these changes

@sveneberth sveneberth sveneberth approved these changes

Assignees
No one assigned
Labels
Priority: Low This issue can be considered with enough idle time.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.7
Development

Successfully merging this pull request may close these issues.

Implement .update(dict_values) on Skeleton/SkeletonInstance
3 participants
@ArneGudermann @phorward @sveneberth