-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database collations #489
Database collations #489
Conversation
/** @var Database $db */ | ||
$db = $service->handler(); | ||
|
||
$db->syncDatabases(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a rollback mechanism and let the user to retry if this fails
app/Models/Database.php
Outdated
public function getStatusText(): string | ||
{ | ||
return match ($this->status) { | ||
DatabaseStatus::READY => 'Ready', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't 😂
@RichardAnderson I added some unit tests. they might fail now but it is expected to pass |
Also, iirc emojis can't be stored correctly with |
@slaFFik this PR uses |
This is true, however, we are attempting to support 3 versions of MySQL, so uft8mb4 is not supported on all of them. I guess for later version we should change the default collation, but at the moment, nothing in the service can identify the version, it's treated generically. |
Pulls the collation and charset information from the database on install.
Syncs the charset information to existing DBs
Provides the ability to specify the charset.
Partially implements synching of DBs.