-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File path corrections for Windows #24
Conversation
It looks almost the same as me first try to fix this issue (see this commit), although you made some nice additional refactoring ;). But this was not working for every one. However your fix is working on my windows computer. But I'm not sure if some functions will be broken if you don't pass the env vars to the spawn command. |
@AlmarAubel I'll take it out the changes to
Might make another PR for it though as I cannot see what they do. Not sure where it comes from or why it's needed. Seems to work on Mac and Windows and may be leftover boiler plate or a mask for a solved issue 🤷♂️ |
Previous changes broke debugging. I pushed a commit that fix the issue. Can you check whether debugging & running tests is working now on your machine? |
@zxch3n looks good and works fine for a normal run. Obviously debug still does not work on my machine but the primary function works well. |
I have not found that the latest updates have helped, but I did find that the path issues identified by @AlmarAubel are the issue. These changes make a single path sanitization function which has solved the issues for
runTest()
(normal) on my Windows 10 machine.I have still been unable to run/fix the
debugTest()
(debug) for my windows machine