-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add better version detection #125
Conversation
@zxch3n any thoughts on the fix? (I can't add you as a reviewer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix should use try
and catch
to avoid throwing in each step, right?
Hey @ngirardin , let me know if you need help making those suggestions from @zxch3n ; happy to help move this forward if there's anything I can do! |
Thanks @zxch3n for the review. I've made some changes to the code:
@arimgibson, sorry for the delay, please let me know if you see something to change on this code :) |
This is a follow-up PR for #118 which have broken some installs:
It seems to fix:
and probably:
vitest.config.ts
from the test file for mono repo #13In some cases, vitest need to be started using
spawn(vitestCommand.cmd, [...vitestCommand.args, '-v'], envs))
, and in other by usingspawn(process.execPath, [vitestCommand.cmd, ...vitestCommand.args, '-v'], envs))
.There are lot of OS / Node install combinations, and I don't have a clear picture of which to use and when.
The easiest fix that I could find, was to try both commands and see which one worked.
It's not the cleanest solution, but I'm open to suggestions :)