test: add TextDecoder/TextEncoder to custom environment example to fix Vite 8#9989
Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom Mar 27, 2026
Merged
Conversation
…#9987) The custom test environment's setupVM() was missing TextDecoder and TextEncoder globals. This caused a ReferenceError with Vite 8, which now uses TextDecoder at the top level of its module-runner. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
changed the title
TextDecoder/TextEncoder to custom VM environment (#9987)TextDecoder/TextEncoder to custom environment example
hi-ogawa
changed the title
TextDecoder/TextEncoder to custom environment exampleTextDecoder/TextEncoder to custom environment example to fix Vite 8
sheremet-va
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ReferenceError: TextDecoder is not defined#9987Vite 8 now access
TextDecoderin module runner vitejs/vite#21985 and it breaks custom vm environment test case. For now, this just fixes on custom environment example side. Our builtin environment (node, jsdom, etc) fills globals includingTextDecoder, so this is only custom environment issue. Not sure if this (Vite 8 change) should be taken as breaking change or not. Probably we can wait. Otherwise, maybe need to fill more context around herevitest/packages/vitest/src/runtime/workers/vm.ts
Lines 81 to 82 in 8f40655
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.