Skip to content

fix: fix URL.name on jsdom #9767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 2 commits into from
Mar 2, 2026
+10 −3
Merged

fix: fix URL.name on jsdom #9767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3d960a
fix: fix `URL.name` on jsdom
hi-ogawa Mar 2, 2026
a628859
refactor: this works actually
hi-ogawa Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/vitest/src/integrations/env/jsdom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export default <Environment>{
}

function createCompatRequest(utils: CompatUtils) {
return class Request extends NodeRequest_ {
class Request extends NodeRequest_ {
constructor(...args: [input: RequestInfo, init?: RequestInit]) {
const [input, init] = args
if (init?.body != null) {
Expand All @@ -254,10 +254,11 @@ function createCompatRequest(utils: CompatUtils) {
return instance instanceof NodeRequest_
}
}
return Request
}

function createJSDOMCompatURL(utils: CompatUtils): typeof URL {
return class URL extends NodeURL {
class URL extends NodeURL {
static createObjectURL(blob: any): string {
if (blob instanceof utils.window.Blob) {
const compatBlob = utils.makeCompatBlob(blob)
Expand All @@ -269,7 +270,8 @@ function createJSDOMCompatURL(utils: CompatUtils): typeof URL {
static [Symbol.hasInstance](instance: unknown): boolean {
return instance instanceof NodeURL
}
} as typeof URL
}
return URL
}

interface CompatUtils {
Expand Down
5 changes: 5 additions & 0 deletions test/core/test/environments/jsdom.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,11 @@ test('URL.createObjectUrl works properly', () => {
}).not.toThrow()
})

test('compat classes preserve their .name property', () => {
expect(URL.name).toBe('URL')
expect(Request.name).toBe('Request')
})

test('jsdom global is exposed', () => {
// @ts-expect-error -- jsdom is not exposed in our types because we use a single tsconfig for all
const dom = jsdom
Expand Down
Loading