Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ export function startVitestModuleRunner(options: ContextModuleRunnerOptions): Vi
return {
code: '',
file: null,
id,
url: id,
id: resolvedMock.id,
url: resolvedMock.url,
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the case of virtual module, here we previously had id = /@id/virtual-module (aka "url") as module runner fetchModule result, which then leaded to evaluatedModuleNode.id = mock:/@id/virtual-module during later mock interception.

However, when invalidating mock for next doMock calls, we use resolveId of virtual-module and it tries to invalidate mock:virtual-module. This inconsistency makes invalidation to miss.

What this resolvedMock case should do instead is to return id as resolvedId of mocked module, which is already available as resolvedMock.id, so that is the solution here.

invalidate: false,
mockedModule: resolvedMock,
}
Expand Down
70 changes: 70 additions & 0 deletions test/core/test/do-mock-reset-modules.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import { expect, test, vi } from 'vitest'

test('multiple resetModules and doMock for indirect actual module', async () => {
vi.doUnmock('./fixtures/increment')

const { incrementIndirect: originalIncrement } = await import('./fixtures/increment-indirect')
expect(originalIncrement(1)).toBe(2)

vi.doMock('./fixtures/increment', () => ({
increment: (num: number) => num + 10,
}))
vi.resetModules()

const { incrementIndirect: incrementWith10 } = await import('./fixtures/increment-indirect')
expect(incrementWith10(1)).toBe(11)

vi.doMock('./fixtures/increment', () => ({
increment: (num: number) => num + 20,
}))
vi.resetModules()

const { incrementIndirect: incrementWith20 } = await import('./fixtures/increment-indirect')
expect(incrementWith20(1)).toBe(21)

vi.doMock('./fixtures/increment', () => ({
increment: (num: number) => num + 30,
}))

const { incrementIndirect: incrementWith20Still } = await import('./fixtures/increment-indirect')
expect(incrementWith20Still(1)).toBe(21)
})

test('multiple doMock for direct virtual module', async () => {
// @ts-expect-error virtual module
const { value: originalValue } = await import('virtual-module-direct')
expect(originalValue).toBe('original-direct')

vi.doMock('virtual-module-direct', () => ({
value: 'direct-1',
}))

// @ts-expect-error virtual module
const { value: mockedValue1 } = await import('virtual-module-direct')
expect(mockedValue1).toBe('direct-1')

vi.doMock('virtual-module-direct', () => ({
value: 'direct-2',
}))

// @ts-expect-error virtual module
const { value: mockedValue2 } = await import('virtual-module-direct')
expect(mockedValue2).toBe('direct-2')
})

test('multiple resetModules and doMock for indirect virtual module', async () => {
const { getVirtualValue: originalGetVirtualValue } = await import('./fixtures/virtual-module-indirect')
expect(originalGetVirtualValue()).toBe('original-indirect')

vi.doMock('virtual-module-indirect', () => ({ value: 'indirect-1' }))
vi.resetModules()

const { getVirtualValue: mockedGetVirtualValue1 } = await import('./fixtures/virtual-module-indirect')
expect(mockedGetVirtualValue1()).toBe('indirect-1')

vi.resetModules()
vi.doMock('virtual-module-indirect', () => ({ value: 'indirect-2' }))

const { getVirtualValue: mockedGetVirtualValue2 } = await import('./fixtures/virtual-module-indirect')
expect(mockedGetVirtualValue2()).toBe('indirect-2')
})
5 changes: 5 additions & 0 deletions test/core/test/fixtures/increment-indirect.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { increment } from './increment'

export function incrementIndirect(num: number) {
return increment(num)
}
6 changes: 6 additions & 0 deletions test/core/test/fixtures/virtual-module-indirect.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// @ts-expect-error virtual module
import { value } from 'virtual-module-indirect'

export function getVirtualValue() {
return value
}
12 changes: 11 additions & 1 deletion test/core/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default defineConfig({
{
name: 'example',
resolveId(source) {
if (source === 'virtual-module') {
if (source === 'virtual-module' || source === 'virtual-module-direct' || source === 'virtual-module-indirect') {
return source
}
},
Expand All @@ -21,6 +21,16 @@ export default defineConfig({
export const value = 'original';
`
}
if (id === 'virtual-module-direct') {
return `
export const value = 'original-direct';
`
}
if (id === 'virtual-module-indirect') {
return `
export const value = 'original-indirect';
`
}
},
},
],
Expand Down
Loading