Skip to content

fix: use object for WeakMap instead of a symbol to support webcontainers #9731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheremet-va merged 1 commit into from
Feb 24, 2026
+5 −5
Merged

fix: use object for WeakMap instead of a symbol to support webcontainers #9731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/runner/src/fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type UserFixtures = Record<string, unknown>
export type FixtureRegistrations = Map<string, TestFixtureItem>

export class TestFixtures {
private _suiteContexts: WeakMap<Suite | symbol, /* context object */ Record<string, unknown>>
private _suiteContexts: WeakMap<Suite | { type: 'worker' }, /* context object */ Record<string, unknown>>
private _overrides = new WeakMap<Suite, FixtureRegistrations>()
private _registrations: FixtureRegistrations

Expand All @@ -34,7 +34,7 @@ export class TestFixtures {

private static _fixtureOptionKeys: string[] = ['auto', 'injected', 'scope']
private static _fixtureScopes: string[] = ['test', 'file', 'worker']
private static _workerContextSymbol = Symbol('workerContext')
private static _workerContextSuite = { type: 'worker' } as const

static clearDefinitions(): void {
TestFixtures._definitions.length = 0
Expand Down Expand Up @@ -103,10 +103,10 @@ export class TestFixtures {
}

getWorkerContext(): Record<string, any> {
if (!this._suiteContexts.has(TestFixtures._workerContextSymbol)) {
this._suiteContexts.set(TestFixtures._workerContextSymbol, Object.create(null))
if (!this._suiteContexts.has(TestFixtures._workerContextSuite)) {
this._suiteContexts.set(TestFixtures._workerContextSuite, Object.create(null))
}
return this._suiteContexts.get(TestFixtures._workerContextSymbol)!
return this._suiteContexts.get(TestFixtures._workerContextSuite)!
}

private parseUserFixtures(
Expand Down
Loading