fix: respect project resolve.conditions for externals

packages/vitest/src/node/pool.ts

@@ -138,8 +138,10 @@ export function createPool(ctx: Vitest): ProcessPool {
 
         let execArgv = projectExecArgvs.get(project)
         if (!execArgv) {
+          const conditions = resolveConditions(project)
           execArgv = [
             ...options.execArgv,
+            ...conditions,
             ...project.config.execArgv,
           ]
           projectExecArgvs.set(project, execArgv)
@@ -236,36 +238,6 @@ export function createPool(ctx: Vitest): ProcessPool {
 }
 
 function resolveOptions(ctx: Vitest) {
-  // in addition to resolve.conditions Vite also adds production/development,
-  // see: https://github.com/vitejs/vite/blob/af2aa09575229462635b7cbb6d248ca853057ba2/packages/vite/src/node/plugins/resolve.ts#L1056-L1080
-  const viteMajor = Number(viteVersion.split('.')[0])
-
-  const potentialConditions = new Set(viteMajor >= 6
-    ? (ctx.vite.config.ssr.resolve?.conditions ?? [])
-    : [
-        'production',
-        'development',
-        ...ctx.vite.config.resolve.conditions,
-      ])
-
-  const conditions = [...potentialConditions]
-    .filter((condition) => {
-      if (condition === 'production') {
-        return ctx.vite.config.isProduction
-      }
-      if (condition === 'development') {
-        return !ctx.vite.config.isProduction
-      }
-      return true
-    })
-    .map((condition) => {
-      if (viteMajor >= 6 && condition === 'development|production') {
-        return ctx.vite.config.isProduction ? 'production' : 'development'
-      }
-      return condition
-    })
-    .flatMap(c => ['--conditions', c])
-
   // Instead of passing whole process.execArgv to the workers, pick allowed options.
   // Some options may crash worker, e.g. --prof, --title. nodejs/node#41103
   const execArgv = process.execArgv.filter(
@@ -278,7 +250,6 @@ function resolveOptions(ctx: Vitest) {
   const options: PoolProcessOptions = {
     execArgv: [
       ...execArgv,
-      ...conditions,
       '--experimental-import-meta-resolve',
       // https://github.com/vitest-dev/vitest/issues/8896
       ...((globalThis as any).Deno || process.versions.pnp ? [] : ['--require', suppressWarningsPath]),
@@ -295,6 +266,39 @@ function resolveOptions(ctx: Vitest) {
   return options
 }
 
+function resolveConditions(project: TestProject) {
+  // in addition to resolve.conditions Vite also adds production/development,
+  // see: https://github.com/vitejs/vite/blob/af2aa09575229462635b7cbb6d248ca853057ba2/packages/vite/src/node/plugins/resolve.ts#L1056-L1080
+  const viteMajor = Number(viteVersion.split('.')[0])
+  const viteConfig = project.vite.config
+
+  const potentialConditions = new Set(viteMajor >= 6
+    ? (viteConfig.ssr.resolve?.conditions ?? [])
+    : [
+        'production',
+        'development',
+        ...(viteConfig.resolve.conditions ?? []),
+      ])
+
+  return [...potentialConditions]
+    .filter((condition) => {
+      if (condition === 'production') {
+        return viteConfig.isProduction
+      }
+      if (condition === 'development') {
+        return !viteConfig.isProduction
+      }
+      return true
+    })
+    .map((condition) => {
+      if (viteMajor >= 6 && condition === 'development|production') {
+        return viteConfig.isProduction ? 'production' : 'development'
+      }
+      return condition
+    })
+    .flatMap(c => ['--conditions', c])
+}
+
 function resolveMaxWorkers(project: TestProject) {
   if (project.config.maxWorkers) {
     return project.config.maxWorkers

test/config/deps/test-dep-conditions-indirect/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "@vitest/test-dep-conditions-indirect",
+  "name": "test-dep-conditions-indirect",
   "type": "module",
   "private": true,
   "exports": {

test/config/deps/test-dep-conditions/indirect.js

@@ -1,8 +1,8 @@
-import conditionCustom from '@vitest/test-dep-conditions-indirect/custom'
-import conditionDevelopment from '@vitest/test-dep-conditions-indirect/development'
-import conditionModule from '@vitest/test-dep-conditions-indirect/module'
-import conditionNode from '@vitest/test-dep-conditions-indirect/node'
-import conditionProductioin from '@vitest/test-dep-conditions-indirect/production'
+import conditionCustom from 'test-dep-conditions-indirect/custom'
+import conditionDevelopment from 'test-dep-conditions-indirect/development'
+import conditionModule from 'test-dep-conditions-indirect/module'
+import conditionNode from 'test-dep-conditions-indirect/node'
+import conditionProductioin from 'test-dep-conditions-indirect/production'
 
 export default {
   conditionCustom,

test/config/deps/test-dep-conditions/package.json

@@ -1,5 +1,5 @@
 {
-  "name": "@vitest/test-dep-conditions",
+  "name": "test-dep-conditions",
   "type": "module",
   "private": true,
   "exports": {
@@ -27,6 +27,6 @@
     "./indirect": "./indirect.js"
   },
   "dependencies": {
-    "@vitest/test-dep-conditions-indirect": "file:../test-dep-conditions-indirect"
+    "test-dep-conditions-indirect": "file:../test-dep-conditions-indirect"
   }
 }

test/config/fixtures/conditions-projects/project-a/basic.test.js

@@ -0,0 +1,37 @@
+import { test, expect } from "vitest";
+import conditionCustom from "test-dep-conditions/custom";
+import conditionModule from "test-dep-conditions/module";
+import conditionNode from "test-dep-conditions/node";
+import conditionDevelopment from "test-dep-conditions/development";
+import conditionProduction from "test-dep-conditions/production";
+import inline from "test-dep-conditions/inline";
+import indirect from "test-dep-conditions/indirect";
+
+import { viteVersion } from "vitest/node";
+const viteMajor = Number(viteVersion.split(".")[0]);
+
+test("conditions", () => {
+  expect({
+    inline,
+    conditionCustom,
+    conditionModule,
+    conditionNode,
+    conditionDevelopment,
+    conditionProduction,
+    indirect,
+  }).toEqual({
+    inline: false,
+    conditionCustom: true,
+    conditionDevelopment: true,
+    conditionModule: viteMajor <= 5,
+    conditionNode: true,
+    conditionProduction: false,
+    indirect: {
+      conditionCustom: true,
+      conditionDevelopment: true,
+      conditionModule: viteMajor <= 5 && inline,
+      conditionNode: true,
+      conditionProductioin: false,
+    },
+  });
+});

test/config/fixtures/conditions-projects/project-a/vitest.config.ts

@@ -0,0 +1,13 @@
+import { defaultServerConditions } from "vite";
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  define: {
+    "import.meta.__IS_INLINE__": "true",
+  },
+  ssr: {
+    resolve: {
+      conditions: ["custom", ...defaultServerConditions.filter((c) => c !== "module")],
+    },
+  },
+});

test/config/fixtures/conditions-projects/project-b/basic.test.js

@@ -0,0 +1,37 @@
+import { test, expect } from "vitest";
+import conditionCustom from "test-dep-conditions/custom";
+import conditionModule from "test-dep-conditions/module";
+import conditionNode from "test-dep-conditions/node";
+import conditionDevelopment from "test-dep-conditions/development";
+import conditionProduction from "test-dep-conditions/production";
+import inline from "test-dep-conditions/inline";
+import indirect from "test-dep-conditions/indirect";
+
+import { viteVersion } from "vitest/node";
+const viteMajor = Number(viteVersion.split(".")[0]);
+
+test("conditions", () => {
+  expect({
+    inline,
+    conditionCustom,
+    conditionModule,
+    conditionNode,
+    conditionDevelopment,
+    conditionProduction,
+    indirect,
+  }).toEqual({
+    inline: false,
+    conditionCustom: false,
+    conditionDevelopment: true,
+    conditionModule: viteMajor <= 5,
+    conditionNode: true,
+    conditionProduction: false,
+    indirect: {
+      conditionCustom: false,
+      conditionDevelopment: true,
+      conditionModule: viteMajor <= 5 && inline,
+      conditionNode: true,
+      conditionProductioin: false,
+    },
+  });
+});

test/config/fixtures/conditions-projects/project-b/vitest.config.ts

@@ -0,0 +1,7 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  define: {
+    "import.meta.__IS_INLINE__": "true",
+  },
+});

test/config/fixtures/conditions-projects/vite.config.ts

@@ -0,0 +1,7 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+  test: {
+    projects: ["project-a", "project-b"],
+  },
+});

test/config/fixtures/conditions/basic.test.js

@@ -1,11 +1,11 @@
 import { test, expect } from 'vitest';
-import conditionCustom from '@vitest/test-dep-conditions/custom';
-import conditionModule from '@vitest/test-dep-conditions/module';
-import conditionNode from '@vitest/test-dep-conditions/node';
-import conditionDevelopment from '@vitest/test-dep-conditions/development';
-import conditionProduction from '@vitest/test-dep-conditions/production';
-import inline from '@vitest/test-dep-conditions/inline';
-import indirect from '@vitest/test-dep-conditions/indirect';
+import conditionCustom from 'test-dep-conditions/custom';
+import conditionModule from 'test-dep-conditions/module';
+import conditionNode from 'test-dep-conditions/node';
+import conditionDevelopment from 'test-dep-conditions/development';
+import conditionProduction from 'test-dep-conditions/production';
+import inline from 'test-dep-conditions/inline';
+import indirect from 'test-dep-conditions/indirect';
 
 import { viteVersion } from 'vitest/node'
 const viteMajor = Number(viteVersion.split('.')[0])

test/config/package.json

@@ -11,12 +11,12 @@
     "@vitest/browser-playwright": "workspace:*",
     "@vitest/browser-preview": "workspace:*",
     "@vitest/browser-webdriverio": "workspace:*",
-    "@vitest/test-dep-conditions": "file:./deps/test-dep-conditions",
     "@vitest/test-dep-optimizer-external": "file:./deps/optimizer/external",
     "@vitest/test-dep-optimizer-optimized": "file:./deps/optimizer/optimized",
     "inline-dep": "file:./deps/vite-ssr-resolve/inline-dep",
     "other-dep": "file:./deps/vite-ssr-resolve/other-dep",
     "ssr-no-external-dep": "file:./deps/vite-ssr-resolve/ssr-no-external-dep",
+    "test-dep-conditions": "file:./deps/test-dep-conditions",
     "tinyexec": "^1.0.2",
     "vite": "latest",
     "vitest": "workspace:*"

test/config/test/conditions-cli.test.ts

@@ -82,7 +82,7 @@ test('conditions (inline direct)', async () => {
     root: 'fixtures/conditions',
     server: {
       deps: {
-        inline: ['@vitest/test-dep-conditions'],
+        inline: ['test-dep-conditions'],
       },
     },
   })
@@ -95,10 +95,31 @@ test('conditions (inline indirect)', async () => {
     root: 'fixtures/conditions',
     server: {
       deps: {
-        inline: ['@vitest/test-dep-conditions', '@vitest/test-dep-conditions-indirect'],
+        inline: ['test-dep-conditions', 'test-dep-conditions-indirect'],
       },
     },
   })
 
   expect(stderr).toBe('')
 })
+
+test('project resolve.conditions', async () => {
+  const { stderr, errorProjectTree } = await runVitest({
+    root: 'fixtures/conditions-projects',
+  })
+  expect(stderr).toBe('')
+  expect(errorProjectTree()).toMatchInlineSnapshot(`
+    {
+      "project-a": {
+        "basic.test.js": {
+          "conditions": "passed",
+        },
+      },
+      "project-b": {
+        "basic.test.js": {
+          "conditions": "passed",
+        },
+      },
+    }
+  `)
+})