fix: fix ui mode / html reporter and coverage integration #9626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use config.coverage.htmlDir in UI and browser dev servers - Serve coverage at standardized /coverage/ path (no more basename heuristic) - Remove resolveCoverageFolder helper functions (~70 lines) - Serialize htmlDir to client config - Update client to check htmlDir and use /coverage/index.html - Remove complex path computation and TODO about subdirectory limitation Benefits: - Predictable coverage URL path - Single source of truth for coverage directory - Simplified client and server logic - No configuration limitations Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Remove stale reportsDirectory subdirectory constraint, document the new coverage.htmlDir option, and update Vitest UI section to reflect that coverage UI now works with both html and lcov reporters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hi-ogawa
force-pushed
the
02-10-chore_repro-6945
branch
from
ce3b606 to
07ca0c7
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hi-ogawa
commented
Feb 11, 2026
Comment on lines
+1374
to
+1380
| // notify builtin ui and html reporter after coverage html is generated | ||
| for (const reporter of this.reporters) { | ||
| if (reporter instanceof WebSocketReporter) { | ||
| reporter.onFinishedReportCoverage() | ||
| if ( | ||
| 'onFinishedReportCoverage' in reporter | ||
| && typeof reporter.onFinishedReportCoverage === 'function' | ||
| ) { | ||
| await reporter.onFinishedReportCoverage() |
Contributor
Author
There was a problem hiding this comment.
reportCoverage happens after onTestRunEnd, so now HTML reporter also needs this to be able to collect coverage html.
Member
There was a problem hiding this comment.
@AriPerkkio that's why I wanted onCoverage as a separate hook, by the way. We have it, but it's coupled to onTestRunEnd
sheremet-va
approved these changes
Feb 11, 2026
AriPerkkio
approved these changes
Feb 11, 2026
Comment on lines
+441
to
+443
| // infer default based on builtin reporter html output (html and lcov) | ||
| if (!resolved.coverage.htmlDir) { | ||
| const htmlReporter = resolved.coverage.reporter.find(([name]) => name === 'html') |
Member
There was a problem hiding this comment.
There's also html-spa if we want to support that 👀
Comment on lines
+397
to
+405
| ## coverage.htmlDir | ||
|
|
||
| - **Type:** `string` | ||
| - **Default:** Automatically inferred from `html` or `lcov` coverage reporters | ||
| - **CLI:** `--coverage.htmlDir=<path>` | ||
|
|
||
| Directory of HTML coverage output to be served in [Vitest UI](/guide/ui) and [HTML reporter](/guide/reporters.html#html-reporter). | ||
|
|
||
| This is automatically configured when using builtin coverage reporters that produce HTML output (`html` and `lcov`). Use this option to override with a custom coverage reporting location when using custom coverage reporters. |
Member
There was a problem hiding this comment.
Should we also mention here that:
Note that setting this option does not change where coverage HTML report is generated. Configure the `reporter` option to change the directory instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies how coverage HTML is served in UI mode and HTML reporter by introducing a new
coverage.htmlDiroption.Before: Coverage HTML serving relied on complex path resolution from
coverage.reportsDirectoryand thehtmlreporter'ssubdiroption. This requiredreportsDirectoryto be set as a subdirectory of the HTML report directory and also inconsistency between ui mode and html reporting.After: Coverage HTML is served at a fixed
./coveragesubpath relative to the UI base. The newcoverage.htmlDiroption is automatically inferred fromhtmlorlcovcoverage reporters, and can be explicitly set for custom coverage providers. This removes the directory layout constraint and makes the integration work reliably across UI mode, HTML reporter, browser mode orchestrator html.TODO
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.