chore(deps): update ast-v8-to-istanbul#9418
Merged
AriPerkkio merged 2 commits intovitest-dev:mainfrom Jan 9, 2026
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
force-pushed
the
chore/coverage-v8-deps
branch
from
c4e75ec to
71be170
Compare
AriPerkkio
force-pushed
the
chore/coverage-v8-deps
branch
from
71be170 to
a84751c
Compare
AriPerkkio
commented
Jan 9, 2026
| } | ||
|
|
||
| /* v8 ignore start */ | ||
| /* todo fix in https://github.com/vitest-dev/vitest/pull/9204 */ |
Member
Author
There was a problem hiding this comment.
These will be fixed in
... where we apply patch for istanbul-lib-coverage so that start/stop ignore hint works on Istanbul provider too, and we can use same snapshot result for both providers.
This started to fail for V8 now due to https://github.com/AriPerkkio/ast-v8-to-istanbul/releases/tag/v0.3.9 as lines were ignored. This is expected.
hi-ogawa
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes fix
This should resolve all identified coverage issues from Rolldown usage.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.