-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
refactor: remove duplicate values from coverage.exclude
#9348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: remove duplicate values from coverage.exclude
#9348
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
What do you mean? It is called once. |
How does your config look like? |
|
This seems more like a bug with |
|
yeah, you are right, it appears that after removing the By the way, I saw in the documentation that |
Technically speaking, the default is empty. Custom excludes don't override "the default". This is just an internal implementation detail of how the coverage providers treat certain files (like unreadable virtual files), it could've been hardcoded inside the provider, for example, but it should probably be mentioned in the docs in some way. |
I have updated the documentation. By default, vitest/packages/vitest/src/node/config/resolveConfig.ts Lines 413 to 414 in 1500654
|


Description
When
vitest --coverageis executed,resolveConfigwill be executed twice.Resolves #issue-number
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.