Skip to content

feat(browser): custom locators API #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 17, 2025

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented May 17, 2025

Description

Closes #7008

Test plan

  • Add new selector that returns a string, it works on page and locator
  • Add new selector that returns a nested string, it works on page and locator
  • Add new method, it works on page and locator

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented May 17, 2025

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 7fdc022
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/682892364eefc0000869070e
😎 Deploy Preview https://deploy-preview-7993--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va merged commit e6fbd8d into vitest-dev:main May 17, 2025
12 of 13 checks passed
@sheremet-va sheremet-va deleted the feat/browser-locators-extend branch May 17, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand locators implementation to support common chaining cases for better parity with Playwright locators
1 participant