-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(reporters): --merge-reports to show each total run times
#7877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reporters): --merge-reports to show each total run times
#7877
Conversation
6ba3c89 to
b996dbf
Compare
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
b996dbf to
67ef233
Compare
4f540be to
d02dca4
Compare
sheremet-va
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I dislike executionTimes?: number[] as a public API.
What are these numbers? Why are the optional? Do we just keep adding new arguments to hooks? I think this needs to be standardized somehow
Maybe have something like a SubTestRun? Or ShardTestRun
|
Do you have any suggestions what would be better way to pass data from |
Storing it in |
d02dca4 to
c2044d7
Compare
|
Storing blobs in |
Description
--merge-reports#7825Adds total test run times of each blob in test report of
--merge-reportsrun. TheDurationis sum of all blobs. Below it we showPer blobdurations.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.