Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update error.ts for inlining a package #6238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

IAmLuisJ
Copy link

Description

Update recommended workaround for inlining a package that has a syntax error when resolving a bundled dependency, since the current workaround uses deprecated config options

close #6237

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

IAmLuisJ added 3 commits July 28, 2024 23:36
Update recommended workaround for inlining a package that has a syntax error when resolving a bundled dependency, since the current workaround uses deprecated config options

close vitest-dev#6237
Update recommended workaround for inlining a package that has a syntax error when resolving a bundled dependency, since the current workaround uses deprecated config options

close vitest-dev#6237
Update recommended workaround for inlining a package that has a syntax error when resolving a bundled dependency, since the current workaround uses deprecated config options

close vitest-dev#6237
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 857b82d
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/66a71e32cee2ea000839dc07
😎 Deploy Preview https://deploy-preview-6238--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

server.deps.inline is not deprecated, deps.inline is

Using optimizer actually won't do anything unless it's enabled

@IAmLuisJ
Copy link
Author

Oh I see. I believe my particular use case was alias configuration in a bundled dependency, which didn't work with the recommended solution. Would it be worth extending the error then instead of replacing it?

@sheremet-va
Copy link
Member

Oh I see. I believe my particular use case was alias configuration in a bundled dependency, which didn't work with the recommended solution. Would it be worth extending the error then instead of replacing it?

How exactly do you want to extend it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update recommended workaround for inlining a package
2 participants