Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): global coverage includes files in glob pattern coverage rules (fix #6165) #6172

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

thor-juhasz
Copy link
Contributor

@thor-juhasz thor-juhasz commented Jul 19, 2024

Description

Fixes #6165.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Comment on lines +12 to +24
thresholds: {
'branches': 100,
'functions': 50,
'lines': isV8Provider() ? 66 : 50,
'statements': isV8Provider() ? 66 : 50,

'**/fixtures/src/even.ts': {
branches: 100,
functions: 100,
lines: 100,
statements: 100,
},
},
Copy link
Member

@AriPerkkio AriPerkkio Jul 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've adjusted these now so that following error is shown when the fix is reverted.

----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |   66.66 |      100 |      50 |   66.66 |                   
 even.ts  |     100 |      100 |     100 |     100 |                   
 math.ts  |      50 |      100 |      25 |      50 | 6-7,10-11,14-15   
----------|---------|----------|---------|---------|-------------------
FAIL  |v8| test/threshold-glob.test.ts > threshold glob patterns count in global coverage
Error: ERROR: Coverage for lines (50%) does not meet global threshold (66%)
ERROR: Coverage for functions (25%) does not meet global threshold (50%)
ERROR: Coverage for statements (50%) does not meet global threshold (66%)


----------|---------|----------|---------|---------|-------------------
File      | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------|---------|----------|---------|---------|-------------------
All files |      50 |      100 |      50 |      50 |                   
 even.ts  |     100 |      100 |     100 |     100 |                   
 math.ts  |      25 |      100 |      25 |      25 | 6-14              
----------|---------|----------|---------|---------|-------------------
FAIL  |istanbul| test/threshold-glob.test.ts > threshold glob patterns count in global coverage
Error: ERROR: Coverage for lines (25%) does not meet global threshold (50%)
ERROR: Coverage for functions (25%) does not meet global threshold (50%)
ERROR: Coverage for statements (25%) does not meet global threshold (50%)

AriPerkkio
AriPerkkio previously approved these changes Jul 20, 2024
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 🙌

I'll review the follow-up feature #6174 soon.

@AriPerkkio AriPerkkio merged commit 02e3f00 into vitest-dev:main Jul 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global coverage threshold should not exclude glob based thresholds
2 participants