-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coverage): global coverage includes files in glob pattern coverage rules (fix #6165) #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
reviewed
Jul 20, 2024
Comment on lines
+12
to
+24
thresholds: { | ||
'branches': 100, | ||
'functions': 50, | ||
'lines': isV8Provider() ? 66 : 50, | ||
'statements': isV8Provider() ? 66 : 50, | ||
|
||
'**/fixtures/src/even.ts': { | ||
branches: 100, | ||
functions: 100, | ||
lines: 100, | ||
statements: 100, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've adjusted these now so that following error is shown when the fix is reverted.
----------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files | 66.66 | 100 | 50 | 66.66 |
even.ts | 100 | 100 | 100 | 100 |
math.ts | 50 | 100 | 25 | 50 | 6-7,10-11,14-15
----------|---------|----------|---------|---------|-------------------
FAIL |v8| test/threshold-glob.test.ts > threshold glob patterns count in global coverage
Error: ERROR: Coverage for lines (50%) does not meet global threshold (66%)
ERROR: Coverage for functions (25%) does not meet global threshold (50%)
ERROR: Coverage for statements (50%) does not meet global threshold (66%)
----------|---------|----------|---------|---------|-------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
----------|---------|----------|---------|---------|-------------------
All files | 50 | 100 | 50 | 50 |
even.ts | 100 | 100 | 100 | 100 |
math.ts | 25 | 100 | 25 | 25 | 6-14
----------|---------|----------|---------|---------|-------------------
FAIL |istanbul| test/threshold-glob.test.ts > threshold glob patterns count in global coverage
Error: ERROR: Coverage for lines (25%) does not meet global threshold (50%)
ERROR: Coverage for functions (25%) does not meet global threshold (50%)
ERROR: Coverage for statements (25%) does not meet global threshold (50%)
AriPerkkio
previously approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! 🙌
I'll review the follow-up feature #6174 soon.
AriPerkkio
approved these changes
Jul 21, 2024
1 task
This was referenced Sep 10, 2024
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6165.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.