Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(browser): move the browser server into its own entity #5924

Merged
merged 17 commits into from
Jun 19, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jun 19, 2024

Description

All browser-related logic is now moved into @vitest/browser package. vitest/node exposes a BrowserServer interface that is implemented by @vitest/browser so we don't need to bundle those types together if @vitest/browser is not used.

There are no more browserProvider/browserRpc/browserState/browserMocker on the workspace project class.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va merged commit 67d6add into vitest-dev:main Jun 19, 2024
16 checks passed
@sheremet-va sheremet-va deleted the refactor/browser-server branch June 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant