-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: simplify browser mode tests #4879
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
Hmm, now main test https://github.com/vitest-dev/vitest/actions/runs/7418249822/job/20185934235?pr=4879#step:11:72 |
1ca0df6
to
094f22d
Compare
094f22d
to
2d6ab00
Compare
This reverts commit 8f38ccd.
After doing random attempt to simplify the minimal repro, it looks like combining Still doing a dirty debugging, but one thing I noticed is that when switching browser test directory by This can be observed by: # first run without --root
$ DEBUG=vite:deps pnpm test-fixtures
# 2nd run with --root
$ DEBUG=vite:deps pnpm test-fixtures --root fixtures/custom-base
vite:deps removing old cache dir /home/hiroshi/code/others/vitest/test/browser/node_modules/.vite/deps
... Also I finally got Playwright/Webkit setup on my PC and I confirmed the same issue happens locally as well (though it's not consistent). The error log is not consistent either, but sometimes I get this log:
|
This reverts commit 0482d8a.
I don't think this simplification particularly matters, so I'll close this. This PR ended up with me investigating Webkit flakiness and I made a simpler repro in a separate PR #4908. |
Description
Extracted a change from #4878
I split this test case into a separate vitest root directory and rewrote
an assertion based on stdout/stderrwithstartVitest
API, so it might be easier to debug.I'm still not sure why the previous approach is failing in some cases in my new PRs, but I thought this simplification would make sense either way.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.