docs(mocking): fix broken msw links #4714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes `node-request-interceptor` mention to `@mswjs/interceptors`. That mention references a rather old library name. Let's stay up-to-date! - Updates the link to learn more about MSW to point to the `/docs` instead of `/docs/recipes` (which doesn't exist anymore). - Updates the `graphql.query()` example because that request handler expects an _operation name_, not the endpoint. Now it's correct.
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LorenzoBloedow
pushed a commit
to LorenzoBloedow/vitest
that referenced
this pull request
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thank you so much for recommending MSW in the Vitest docs!
I was reading through the docs and found a few issues/outdated links so I opened this pull request.
node-request-interceptormention to@mswjs/interceptors. That mention references a rather old library name. Let's stay up-to-date!/docsinstead of/docs/recipes(which doesn't exist anymore).graphql.query()example because that request handler expects an operation name, not the endpoint. Now it's correct.Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.