-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(vitest): reimplement hoistMocks to fix incorrect dynamic imports #4664
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
I cannot accept this PR without tests. Vitest is a testing framework and the lack of tests for our own features is not a good sign. Initially, this was an experimental feature to test how it works, but now it does more than before. Since it doesn't use Vite's SSR transformer directly, we need to have tests in our repo. You can just copy SSR transformer tests from Vite. |
Sorry! I finally got what you meant. I will add these tests later |
I added tests and made some changes. Since the |
Description
fix: #4619
fix: #4604
fix: #3300
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.