Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run tests in sequential suite sequentially with sequence.concurrent #4481

Closed
wants to merge 1 commit into from
Closed

fix: run tests in sequential suite sequentially with sequence.concurrent #4481

wants to merge 1 commit into from

Conversation

dsyddall
Copy link
Contributor

Description

Fixes #4473

Currently, when running Vitest with the --sequence.concurrent CLI option or with the sequence.concurrent config option set to true, describe.sequential has no effect and tests run concurrently.

This PR fixes the issue by correcting a typo causing the sequential option to not be passed to the task collector.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit a037c86
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/655014d000417e000856c330
😎 Deploy Preview https://deploy-preview-4481--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dsyddall dsyddall changed the title Run tests in sequential suite sequentially with sequence.concurrent fix: run tests in sequential suite sequentially with sequence.concurrent Nov 11, 2023
@dsyddall
Copy link
Contributor Author

Merged with #4482

@dsyddall dsyddall closed this Nov 15, 2023
@dsyddall dsyddall deleted the fix-sequence-concurrent-describe-sequential branch November 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When sequence.concurrent is true, tests in a sequential suite run concurrently
1 participant