Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vitest): don't start the server when optimizer is enabled #4095

Merged
merged 4 commits into from
Sep 8, 2023
Merged

fix(vitest): don't start the server when optimizer is enabled #4095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe5a5ff
fix(vitest): don't start the server when optimizer is enabled
sheremet-va Sep 8, 2023
b0dc4bb
chore: cleanup
sheremet-va Sep 8, 2023
3635486
chore: cleanup
sheremet-va Sep 8, 2023
ccf618d
chore: cleanup
sheremet-va Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: cleanup
  • Loading branch information
@sheremet-va
sheremet-va committed Sep 8, 2023
commit 363548654bd774bda10d187efdf1129375428311
3 changes: 3 additions & 0 deletions packages/vitest/src/integrations/browser/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ export async function createBrowserServer(project: WorkspaceProject, configFile:
port: defaultBrowserPort,
}

// browser never runs in middleware mode
server.middlewareMode = false

config.server = server
config.server.fs ??= {}
config.server.fs.allow = config.server.fs.allow || []
Expand Down
5 changes: 1 addition & 4 deletions packages/vitest/src/node/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,7 @@ export async function initializeProject(workspacePath: string | number, ctx: Vit
],
}

const server = await createServer(config)

if (ctx.config.api?.port)
await server.listen()
await createServer(config)

return project
}
Expand Down