Fix: Removing obsolete warning from undesired snapshots #4009
Conversation
|
|
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| getTasks(suite).forEach((suiteTask) => { | ||
| if (suiteTask.mode === 'skip') { | ||
| getTasks(suiteTask).forEach((task) => { |
There was a problem hiding this comment.
I don't think there are any tasks here when suite is skipped. We skip collection phase altogether
There was a problem hiding this comment.
Weird, I was logging the tasks and they were there. The warning is also not happening anymore as reported in the issue.
There was a problem hiding this comment.
Yeah, the tasks are there but they have mode: 'skip'
samkevin1
force-pushed
the
obsolete-warning-snapshots
branch
from
9c2a69a
to
19c4f7c
Compare
|
@sheremet-va Added the tests, not sure why the CI is failing though. |
| }) | ||
| } | ||
|
|
||
| describe('snapshot should not be obsolete', () => { |
There was a problem hiding this comment.
When I run this test without your changes, it gives the same result. Your tests should validate that the change that you made is working.
If you just run this command in main, you can see that there are already no obsolete warnings. Please, create a test that actually tests things.
Description
This PR removes the
obsolete snapshotwarning from skipped suite tests.Related to #2442.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.