Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import performance from perf_hooks in __vitest_worker__ #3159

Closed
wants to merge 2 commits into from
Closed

fix: import performance from perf_hooks in __vitest_worker__ #3159

wants to merge 2 commits into from

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Apr 10, 2023 •
edited
Loading

Refs: #3158

@stackblitz
Copy link

stackblitz bot commented Apr 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@trivikr trivikr mentioned this pull request Apr 10, 2023
Closed
6 tasks
@danez
Copy link
Contributor

danez commented Apr 10, 2023

I don't think it solves #3158 completely as AggregateError is still used, but doesn't exist on Node.js 14.

@trivikr
Copy link
Contributor Author

trivikr commented Apr 10, 2023 •
edited
Loading

I don't think it solves #3158 completely

It solves the specific error I'm facing though.
I changed "Fixed" to "Refs" so that issue with AggregateError is kept open.

@sheremet-va sheremet-va mentioned this pull request Apr 11, 2023
Merged
@trivikr trivikr deleted the add-perf-hooks-import branch April 11, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivikr @danez