Repository navigation
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11668
In Edge,
toHaveStylebuilt the expected styles from an empty computed style, so a check liketoHaveStyle({ display: 'grid' })failed withdisplay:on the expected side even when the element really was a grid. The two browser checks intoHaveStyle.tsonly listed Chromium, and Edge is Chromium-based too, so I addededgenext to it in both places.I added a test that follows the repro from the issue. I ran it in real Edge (155, headless, webdriverio): on main it fails with the same
- display: ; + display: grid;diff from the issue, and with this change all 15toHaveStyletests pass. Chromium is unchanged.One caveat: CI doesn't run Edge, so the new test passes in Chromium there with or without the fix. Happy to drop it or move it somewhere else if you'd prefer.