Repository navigation
fix(browser): report mock conflicts between non-isolated files - #11643
Draft
sheremet-va wants to merge 1 commit into
Draft
sheremet-va wants to merge 1 commit into
sheremet-va wants to merge 1 commit into
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
isolate: false, the test files of a page share one document and one module instance per URL. A mock cannot replace a module that the page already imported, and a mock stays in the page for the files that run after it. Both cases now fail the test file with an error that names the module and the file that imported it first, instead of returning the wrong module. The same mock registered again from the same importer, like a setup file, is still accepted. The docs describe what works without isolation.Refs #8933