Repository navigation
chore: migrate to oxc - #11367
chore: migrate to oxc#11367
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }, | ||
| "ignorePatterns": [ | ||
| "**/fixtures", | ||
| "**/*.d.ts", |
There was a problem hiding this comment.
What's the reason for ignoring declaration files?
There was a problem hiding this comment.
It was already in eslint config, at the time I think it was breaking dts files copied from jest-dom. In general there are few of them and they are not edited frequently, I think we can manage it on our own
There was a problem hiding this comment.
Nice!
Looks like CI went down from 47s to 3s
- Before:
eslint --cache .took 47.7s - After:
oxlint && oxfmt --checktook 3.1s
There was a problem hiding this comment.
nit. Can we switch to jsonc config? Just to avoid red-squiggles on some viewer. oxlint may also switch to jsonc config since we may want some comment inside.
There was a problem hiding this comment.
I think jsonc is fine. Using js/ts would require a js runtime while json/jsonc could just be consumed by rust (which is faster)
Providing a $schema also enables autocomplete for rules which is the only benefit of a ts/js config
There was a problem hiding this comment.
Does autocomplete somehow cover custom plugins too?
There was a problem hiding this comment.
It only covers plugins that oxc supports (the ones in plugins array - like unicorn/vue/import/jsdoc, it doesn't support jsPlugins obv)
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Awesome! Need to take closer look later. I also started same thing last week, maybe there's something for reference:
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good like this. We can always fine tune rules in follow-up PRs.
4 participants
It's time