fix(vm): do not optimize deps from index.html (fix #11329)

.oxfmtrc.jsonc

@@ -43,5 +43,6 @@
     "test/workspaces-browser/results.json",
     "test/e2e/deps/error",
     "test/e2e/deps/malformed-source-map",
+    "test/e2e/deps/optimizer/unparsable",
   ],
 }

packages/vitest/src/node/plugins/runnerTransform.ts

@@ -59,7 +59,7 @@ export function ModuleRunnerTransform(): VitePlugin {
     configEnvironment: {
       order: 'post',
       handler(name, config) {
-        if (name === '__vitest_vm__' || name === '__vitest__') {
+        if (name === '__vitest__') {
           return
         }
         // In browser mode the `client` environment (and any other environment
@@ -70,6 +70,14 @@ export function ModuleRunnerTransform(): VitePlugin {
           return
         }
 
+        const optimizerOptions =
+          name === '__vitest_vm__' ? undefined : testConfig?.deps?.optimizer?.[name]
+        config.optimizeDeps = resolveOptimizerConfig(optimizerOptions, config.optimizeDeps)
+
+        if (name === '__vitest_vm__') {
+          return
+        }
+
         config.resolve ??= {}
 
         // remove Vite's externalization logic because we have our own (unfortunately)
@@ -83,11 +91,6 @@ export function ModuleRunnerTransform(): VitePlugin {
         // to externalize modules and always resolve static imports
         // in both SSR and Client environments
         config.resolve.noExternal = true
-
-        config.optimizeDeps = resolveOptimizerConfig(
-          testConfig?.deps?.optimizer?.[name],
-          config.optimizeDeps,
-        )
       },
     },
   }

test/e2e/deps/optimizer/unparsable/index.js

@@ -0,0 +1,5 @@
+// This package has invalid JavaScript so the test fails if Vite's optimizer
+// scans the dependency imported from index.html.
+export default function broken(input: {| value: string |}) {
+  return input.value
+}

test/e2e/deps/optimizer/unparsable/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "@vitest/test-dep-optimizer-unparsable",
+  "type": "module",
+  "private": true,
+  "main": "./index.js"
+}

test/e2e/fixtures/vm-optimizer/basic.test.ts

@@ -0,0 +1,5 @@
+import { expect, test } from 'vitest'
+
+test('unrelated to the index.html graph', () => {
+  expect(1).toBe(1)
+})

test/e2e/fixtures/vm-optimizer/index.html

@@ -0,0 +1,2 @@
+<!doctype html>
+<html><body><script type="module" src="/main.js"></script></body></html>

test/e2e/fixtures/vm-optimizer/main.js

@@ -0,0 +1 @@
+import '@vitest/test-dep-optimizer-unparsable'

test/e2e/package.json

@@ -29,6 +29,7 @@
     "@vitest/mocker": "workspace:*",
     "@vitest/test-dep-optimizer-external": "file:./deps/optimizer/external",
     "@vitest/test-dep-optimizer-optimized": "file:./deps/optimizer/optimized",
+    "@vitest/test-dep-optimizer-unparsable": "file:./deps/optimizer/unparsable",
     "@vitest/utils": "workspace:*",
     "ansivision": "catalog:",
     "flatted": "catalog:",

test/e2e/test/vm-optimizer.test.ts

@@ -0,0 +1,21 @@
+import { expect, test } from 'vitest'
+import { runVitest } from '../../test-utils'
+
+test.for(['forks', 'threads', 'vmThreads', 'vmForks'])(
+  'does not optimize dependencies discovered from index.html - %s',
+  async (pool) => {
+    const { stderr, testTree } = await runVitest({
+      root: './fixtures/vm-optimizer',
+      pool,
+    })
+
+    expect(stderr).toBe('')
+    expect(testTree()).toMatchInlineSnapshot(`
+      {
+        "basic.test.ts": {
+          "unrelated to the index.html graph": "passed",
+        },
+      }
+    `)
+  },
+)