Repository navigation
fix(expect): use iterableEquality in value matchers - #11304
Closed
sahiljadhav7 wants to merge 2 commits into
Closed
sahiljadhav7 wants to merge 2 commits into
sahiljadhav7 wants to merge 2 commits into
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sahiljadhav7
force-pushed
the
fix/expect-iterable-equality
branch
2 times, most recently
from
September 19, 2026 13:26
fa5734b to
d681710
Compare
sahiljadhav7
force-pushed
the
fix/expect-iterable-equality
branch
from
September 29, 2026 19:34
d681710 to
8e22b0b
Compare
…-equality # Conflicts: # packages/expect/src/custom-matchers.ts
Collaborator
|
closed by #11402 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11296
toContainEqual,toHaveProperty,toBeOneOfand the six return/resolve matchers compared Maps and Sets withoutiterableEquality, so any two of them matched. The six return/resolve matchers also droppedcustomTesters, soexpect.addEqualityTestersdid not reach them.