chore!: remove vitest/import-meta reexport - #10331
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Looks like flakes maybe? |
| "types": "./importMeta.d.ts" | ||
| }, | ||
| "./import-meta": { | ||
| "types": "./import-meta.d.ts" |
There was a problem hiding this comment.
I think we should still keep ./import-meta - just use importMeta.d.ts types for it
There was a problem hiding this comment.
I'm mildly confused-why? The point of this PR is that the import-meta export isn't necessary anymore.
If we want to keep import-meta, shouldn't we close this PR as wontfix?
There was a problem hiding this comment.
I think this is more of a preference issue. Using import-meta or importMeta should just be a decision by the user, it could be non-breaking. If we need to remove anything, it should be the comment
We also generally use - for exports (see optional-types and optional-runtime-types above)
2 participants
Description
Deletes vitest/import-meta, as proposed in #10330.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.