fix(runner): use per-group limiter for DFS-bounded concurrent scheduling#10108
Draft
hi-ogawa wants to merge 3 commits intovitest-dev:mainfrom
Draft
fix(runner): use per-group limiter for DFS-bounded concurrent scheduling#10108hi-ogawa wants to merge 3 commits intovitest-dev:mainfrom
hi-ogawa wants to merge 3 commits intovitest-dev:mainfrom
Conversation
Replace the global `limitMaxConcurrency` (FIFO, per-operation) with short-lived per-group limiter instances created at each concurrent dispatch point. Each child holds one slot for its entire subtree duration, producing DFS-ordered execution with bounded parallelism. Guarantee: at any concurrent group, at most `maxConcurrency` subtrees are simultaneously in-flight, bounding resource ownership at every level of the task tree (not just at leaf tests). Fixes vitest-dev#10097 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Okay, this looks like a genuinly hard (or impossible) problem. I'm leaning towards reverting #9653. I think the state before that PR already had the most practical trade-off. Any new "solution" will probably becomes the matter of introducing opt-in/out to let uses choose certain behavior e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
concurrent#10069I thought I had a clean picture and solution in #9653, but it turns out to be a wrong way to model concurrency for test execution (even though what's claimed in the PR is still "mathematically correct"). This PR revised the approach to limit concurrency at each concurrency branches (i.e.
Promise.all) instead of scattering through all leaf calls. This model should fit better howconcurrentbehaves for testing scenarios.Hmm, well this is actually quite different (too simplified) model and loose about global limit for nested
describe.concurrent. The new model might be actually intuitive and fine, but let me explore if we have somehow solution to keep both good parts.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.