Skip to content

refactor: use custom matcher for domain snapshot#10041

Closed
hi-ogawa wants to merge 247 commits intovitest-dev:mainfrom
hi-ogawa:feat-custom-matcher-domain-snapshot
Closed

refactor: use custom matcher for domain snapshot#10041
hi-ogawa wants to merge 247 commits intovitest-dev:mainfrom
hi-ogawa:feat-custom-matcher-domain-snapshot

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Apr 2, 2026

Description

I'm thinking to use custom matcher mechanism for domain snapshot instead of exposing addDomainSnapshot, builtin toMatchDomainSnapshot etc.. Nothing should change for ARIA snapshot API surface, so putting this separate (as I don't want to block that one forever).

One blocker is integrating with vanilla expect.poll mechanism. We currently hard-code toMatchDomainSnapshot so that expect.poll will delegate retry logic to pollMatchDomain.

TODO

  • allow expect.extend to specify options to let matchers to take over poll logic
  • remove unneeded domain snapshot API surfaces
  • docs

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 03fdbed
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69cf684d95b289000828ac9e
😎 Deploy Preview https://deploy-preview-10041--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

hi-ogawa commented Apr 6, 2026

This is merged via hi-ogawa#5

@hi-ogawa hi-ogawa reopened this Apr 6, 2026
@hi-ogawa hi-ogawa closed this Apr 6, 2026
@hi-ogawa hi-ogawa deleted the feat-custom-matcher-domain-snapshot branch April 6, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant