feat: add minimal YAML parser for aria snapshot templates#13
Merged
hi-ogawa merged 12 commits intovitest-dev:masterfrom Mar 19, 2026
Merged
feat: add minimal YAML parser for aria snapshot templates#13hi-ogawa merged 12 commits intovitest-dev:masterfrom
hi-ogawa merged 12 commits intovitest-dev:masterfrom
Conversation
Self-contained parser (~600 lines) that supports the YAML subset needed by ariaSnapshot.ts: sequences, maps, scalars (plain, quoted, numeric, boolean), and indentation-based nesting. Includes unit tests (73 cases) ported from vendor/yaml/tests/ and covering every YAML shape used in test/aria.test.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
38 tasks
sheremet-va
approved these changes
Mar 19, 2026
Member
sheremet-va
left a comment
sheremet-va
left a comment
There was a problem hiding this comment.
Didn't notice how big it was
Collaborator
Author
|
Okay, AI said ported/forked but it looks like the implementation is done from scratch 🙃 The code looks sound and a way clearer than original, but let me spend a bit for review. |
commit: |
Collaborator
Author
|
I added the document Ideally, we should have better yaml parsing test coverage, but since we own the aria yaml generation side, adopting this minimal implementation should be good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI port of minimal
yamlparser to support aria snapshot needs. Got significant size decrease:yamlpackagesrc/aria/yaml.tsFor comparison, current
@vitest/browser'sexpect-element.jsis 23kb.