fix(consistent-test-filename): correct options type

[paescuj]

Fixes #799

In #785 the options schema was corrected from the previously invalid schema

eslint-plugin-vitest/src/rules/consistent-test-filename.ts

Lines 33 to 38 in 4321439

	pattern: {
	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
	// @ts-expect-error
	format: 'regex',
	default: defaultPattern.source,
	},

to a valid one

eslint-plugin-vitest/src/rules/consistent-test-filename.ts

Lines 33 to 37 in 0d82d1e

	pattern: {
	type: 'string',
	format: 'regex',
	default: defaultPattern.source,
	},

As pointed out in #799 it used to be possible to use a RegExp for the rules options (due to the invalid schema and options retrievement via context).

Since, according to the official ESLint documentation ¹, rule options need to consist of JSON data types, I would stick with the fixed schema, which means the options must be passed as a string regex, for example:

    'vitest/consistent-test-filename': ['error', { pattern: '.*\.test\.[tj]sx?$' }]
    // or if preferred
    'vitest/consistent-test-filename': ['error', { pattern: /.*\.test\.[tj]sx?$/.source }]

However, what I've missed in #785 is that the Options type should also just accept strings and that it makes more sense to pass the default options in this format as well.

Footnotes

1. https://eslint.org/docs/latest/use/configure/configuration-files#configuring-rules ↩

[veritem]

thanks