fix: correct and align retrievement of rule options

src/rules/consistent-test-filename.ts

@@ -8,8 +8,8 @@ const defaultTestsPattern = /.*\.(test|spec)\.[tj]sx?$/
 export default createEslintRule<
   [
     Partial<{
-      pattern: string
-      allTestPattern: string
+      pattern: RegExp | string
+      allTestPattern: RegExp | string
     }>,
   ],
   'consistentTestFilename'
@@ -20,7 +20,7 @@ export default createEslintRule<
     docs: {
       recommended: false,
       requiresTypeChecking: false,
-      description: 'require .spec test file pattern',
+      description: 'require test file pattern',
     },
     messages: {
       consistentTestFilename: 'Use test file name pattern {{ pattern }}',
@@ -31,14 +31,12 @@ export default createEslintRule<
         additionalProperties: false,
         properties: {
           pattern: {
-            // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-            // @ts-expect-error
+            type: 'string',
             format: 'regex',
             default: defaultPattern.source,
           },
           allTestPattern: {
-            // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-            // @ts-expect-error
+            type: 'string',
             format: 'regex',
             default: defaultTestsPattern.source,
           },
@@ -48,23 +46,21 @@ export default createEslintRule<
   },
   defaultOptions: [
     {
-      pattern: defaultTestsPattern.source,
-      allTestPattern: defaultTestsPattern.source,
+      pattern: defaultPattern,
+      allTestPattern: defaultTestsPattern,
     },
   ],
 
-  create: (context) => {
-    const config = context.options[0] ?? {}
-    const {
-      pattern: patternRaw = defaultPattern,
-      allTestPattern: allTestPatternRaw = defaultTestsPattern,
-    } = config
+  create: (context, options) => {
+    const { pattern: patternRaw, allTestPattern: allTestPatternRaw } =
+      options[0]
+
     const pattern =
-      typeof patternRaw === 'string' ? new RegExp(patternRaw) : patternRaw
+      typeof patternRaw === 'string' ? new RegExp(patternRaw) : patternRaw!
     const testPattern =
       typeof allTestPatternRaw === 'string'
         ? new RegExp(allTestPatternRaw)
-        : allTestPatternRaw
+        : allTestPatternRaw!
 
     const { filename } = context
 

src/rules/consistent-test-it.ts

@@ -79,12 +79,11 @@ export default createEslintRule<
       },
     ],
   },
-  defaultOptions: [{ fn: TestCaseName.test, withinDescribe: TestCaseName.it }],
-  create(context) {
-    const config = context.options[0] ?? {}
-    const testFnKeyWork = config.fn || TestCaseName.test
-    const testKeywordWithinDescribe =
-      config?.withinDescribe || config?.fn || TestCaseName?.it
+  defaultOptions: [{}],
+  create(context, options) {
+    const { fn, withinDescribe } = options[0]
+    const testFnKeyWork = fn || TestCaseName.test
+    const testKeywordWithinDescribe = withinDescribe || fn || TestCaseName.it
     const testFnDisabled =
       testFnKeyWork === testKeywordWithinDescribe ? testFnKeyWork : undefined
 

src/rules/consistent-vitest-vi.ts

@@ -29,16 +29,16 @@ export default createEslintRule<[Partial<{ fn: UtilName }>], MESSAGE_ID>({
           fn: {
             type: 'string',
             enum: [UtilName.vi, UtilName.vitest],
+            default: UtilName.vi,
           },
         },
         additionalProperties: false,
       },
     ],
   },
   defaultOptions: [{ fn: UtilName.vi }],
-  create(context) {
-    const config = context.options[0] ?? {}
-    const utilKeyword = config.fn || UtilName.vi
+  create(context, options) {
+    const utilKeyword = options[0].fn!
     const oppositeUtilKeyword = getOppositeVitestUtilKeyword(utilKeyword)
 
     return {

src/rules/no-focused-tests.ts

@@ -45,8 +45,8 @@ export default createEslintRule<Options, MessageIds>({
     },
   },
   defaultOptions: [{ fixable: true }],
-  create: (context) => {
-    const fixable = context.options[0]?.fixable
+  create: (context, options) => {
+    const fixable = options[0].fixable!
 
     return {
       ExpressionStatement(node) {

src/rules/require-hook.ts

@@ -84,12 +84,12 @@ export default createEslintRule<Options, MESSAGE_IDS>({
       allowedFunctionCalls: [],
     },
   ],
-  create(context) {
-    const { allowedFunctionCalls } = context.options[0] ?? {}
-
+  create(context, options) {
     const checkBlockBody = (body: TSESTree.BlockStatement['body']) => {
       for (const statement of body) {
-        if (shouldBeInHook(statement, context, allowedFunctionCalls)) {
+        if (
+          shouldBeInHook(statement, context, options[0].allowedFunctionCalls)
+        ) {
           context.report({
             node: statement,
             messageId: 'useHook',

src/rules/require-top-level-describe.ts

@@ -31,15 +31,17 @@ export default createEslintRule<Options, MESSAGE_IDS>({
           maxNumberOfTopLevelDescribes: {
             type: 'number',
             minimum: 1,
+            default: Infinity,
           },
         },
         additionalProperties: false,
       },
     ],
   },
-  defaultOptions: [{}],
-  create(context) {
-    const { maxNumberOfTopLevelDescribes = Infinity } = context.options[0] ?? {}
+  defaultOptions: [{ maxNumberOfTopLevelDescribes: Infinity }],
+  create(context, options) {
+    const maxNumberOfTopLevelDescribes =
+      options[0].maxNumberOfTopLevelDescribes!
 
     let numberOfTopLevelDescribeBlocks = 0
     let numberOfDescribeBlocks = 0

tests/consistent-test-filename.test.ts

@@ -6,15 +6,18 @@ ruleTester.run(`file-name`, rule, {
     {
       code: 'export {}',
       filename: '1.test.ts',
-      options: [{ pattern: String.raw`.*\.test\.ts$` }],
+    },
+    {
+      code: 'export {}',
+      filename: '1.spec.ts',
+      options: [{ pattern: String.raw`.*\.spec\.ts$` }],
     },
   ],
   invalid: [
     {
       code: 'export {}',
       filename: '1.spec.ts',
       errors: [{ messageId: 'consistentTestFilename' }],
-      options: [{ pattern: String.raw`.*\.test\.ts$` }],
     },
     {
       code: 'export {}',
@@ -23,7 +26,7 @@ ruleTester.run(`file-name`, rule, {
       options: [
         {
           allTestPattern: String.raw`__tests__`,
-          pattern: String.raw`.*\.test\.ts$`,
+          pattern: String.raw`.*\.spec\.ts$`,
         },
       ],
     },

tests/consistent-vitest-vi.test.ts

@@ -6,29 +6,24 @@ ruleTester.run(RULE_NAME, rule, {
   valid: [
     {
       code: 'import { expect, it } from "vitest";',
-      options: [{ fn: UtilName.vi }],
     },
     {
       code: 'import { vi } from "vitest";',
-      options: [{ fn: UtilName.vi }],
     },
     {
       code: 'import { vitest } from "vitest";',
       options: [{ fn: UtilName.vitest }],
     },
     {
       code: 'import { vi } from "vitest";\nvi.stubEnv("NODE_ENV", "production");',
-      options: [{ fn: UtilName.vi }],
     },
     {
       code: 'vi.stubEnv("NODE_ENV", "production");',
-      options: [{ fn: UtilName.vi }],
     },
   ],
   invalid: [
     {
       code: 'import { vitest } from "vitest";',
-      options: [{ fn: UtilName.vi }],
       output: 'import { vi } from "vitest";',
       errors: [
         {
@@ -45,7 +40,6 @@ ruleTester.run(RULE_NAME, rule, {
     },
     {
       code: 'import { expect, vi, vitest } from "vitest";',
-      options: [{ fn: UtilName.vi }],
       output: 'import { expect, vi } from "vitest";',
       errors: [
         {
@@ -62,7 +56,6 @@ ruleTester.run(RULE_NAME, rule, {
     },
     {
       code: 'import { vitest } from "vitest";\nvitest.stubEnv("NODE_ENV", "production");',
-      options: [{ fn: UtilName.vi }],
       output:
         'import { vi } from "vitest";\nvi.stubEnv("NODE_ENV", "production");',
       errors: [

tests/no-focused-tests.test.ts

@@ -5,6 +5,11 @@ ruleTester.run(RULE_NAME, rule, {
   valid: ['it("test", () => {});', 'describe("test group", () => {});'],
   invalid: [
     {
+      options: [
+        {
+          fixable: false,
+        },
+      ],
       code: 'it.only("test", () => {});',
       errors: [
         {
@@ -108,11 +113,6 @@ ruleTester.run(RULE_NAME, rule, {
   valid: ['it("test", () => {});', 'describe("test group", () => {});'],
   invalid: [
     {
-      options: [
-        {
-          fixable: true,
-        },
-      ],
       code: 'it.only("test", () => {});',
       errors: [
         {
@@ -126,11 +126,6 @@ ruleTester.run(RULE_NAME, rule, {
       output: 'it("test", () => {});',
     },
     {
-      options: [
-        {
-          fixable: true,
-        },
-      ],
       code: 'describe.only("test", () => {});',
       errors: [
         {
@@ -144,11 +139,6 @@ ruleTester.run(RULE_NAME, rule, {
       output: 'describe("test", () => {});',
     },
     {
-      options: [
-        {
-          fixable: true,
-        },
-      ],
       code: 'test.only("test", () => {});',
       errors: [
         {
@@ -162,11 +152,6 @@ ruleTester.run(RULE_NAME, rule, {
       output: 'test("test", () => {});',
     },
     {
-      options: [
-        {
-          fixable: true,
-        },
-      ],
       code: 'it.only.each([])("test", () => {});',
       errors: [
         {
@@ -180,11 +165,6 @@ ruleTester.run(RULE_NAME, rule, {
       output: 'it.each([])("test", () => {});',
     },
     {
-      options: [
-        {
-          fixable: true,
-        },
-      ],
       code: 'test.only.each``("test", () => {});',
       errors: [
         {
@@ -198,11 +178,6 @@ ruleTester.run(RULE_NAME, rule, {
       output: 'test.each``("test", () => {});',
     },
     {
-      options: [
-        {
-          fixable: true,
-        },
-      ],
       code: 'it.only.each``("test", () => {});',
       errors: [
         {