vttablet: Open and Close healthStreamer #6515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing unit test looks like it might be flaky, it will be good to fix that. |
While running tests, we found that grpc would occasionally send a spurious value if the tablet was shutdown while a stream was still open. This packet was confusing vtgate's healthcheck. This change makes sure that all health streams are stopped before we shutdown. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running tests, we found that grpc would occasionally send
a spurious value if the tablet was shutdown while a stream was
still open. This packet was confusing vtgate's healthcheck.
This change makes sure that all health streams are stopped before
we shutdown.
Signed-off-by: Sugu Sougoumarane ssougou@gmail.com