Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: HandleSet in executor to handle multiple settings in single set statement #6504

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Backport: HandleSet in executor to handle multiple settings in single set statement #6504

merged 1 commit into from
Aug 14, 2020

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 30, 2020 •
edited by deepthi
Loading

Backport #6495

@harshit-gangal @systay
HandleSet in executor to handle multiple settings in single set state…
e2c2413 
…ment

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay systay requested a review from sougou as a code owner July 30, 2020 11:06
@deepthi
Copy link
Member

deepthi commented Aug 11, 2020

Also a problem in 6.0. Re-review if someone is affected and backport to both 6.0 and 7.0.

@deepthi deepthi closed this Aug 11, 2020
@deepthi
Copy link
Member

deepthi commented Aug 12, 2020

Let us backport to 6.0 and then forward-port to 7.0.

@deepthi deepthi added this to the v6.0-20200825 milestone Aug 12, 2020
@deepthi
Copy link
Member

deepthi commented Aug 14, 2020

Backported to 6.0 in #6566

@deepthi deepthi removed this from the v6.0-20200825 milestone Aug 14, 2020
@deepthi deepthi reopened this Aug 14, 2020
@deepthi deepthi added this to the 7.0.1 milestone Aug 14, 2020
deepthi
deepthi approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit-gangal harshit-gangal merged commit 7c7c068 into vitessio:release-7.0 Aug 14, 2020
@harshit-gangal harshit-gangal deleted the bp-6495 branch August 14, 2020 20:06
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@systay @deepthi @sougou @harshit-gangal