Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vreplication Cross-cell source: add support for cells in reshard #6456

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Vreplication Cross-cell source: add support for cells in reshard #6456

merged 4 commits into from
Jul 22, 2020

Conversation

rohit-nayak-ps
Copy link
Contributor

No description provided.

@rohit-nayak-ps
Vrepl Crosscell: add cell/tablettypes to reshard command
5ed5fa0 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
VRepl Cross-cell source: add cell/tablet_types for reshard, rename ce…
d5192f1 
…ll to cells (breaking change), updated cross-cell tests to add reshard

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Vrepl Crosscell: fix linter error, remove unused code
ac67c7b 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review July 20, 2020 14:53
@rohit-nayak-ps rohit-nayak-ps requested a review from sougou as a code owner July 20, 2020 14:53
@rohit-nayak-ps rohit-nayak-ps requested a review from deepthi July 21, 2020 12:40
deepthi
deepthi reviewed Jul 21, 2020
View reviewed changes
@deepthi
Copy link
Member

deepthi commented Jul 22, 2020

@rohit-nayak-ps can you also enable these tests in CI? Then we can close #6453

@rohit-nayak-ps
VRepl Crosscell: address review comments
2513e1a 
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Copy link
Contributor Author

@rohit-nayak-ps can you also enable these tests in CI? Then we can close #6453

Github CI seems backed up today: tests have been queued up for a couple of hours. Will enable the repl e2e once tests pass. But I thought you had issues with the VM configuration in #6453? You mentioned breaking up the tests in the last Vitess call, but TestBasicVreplicationWorkflow was explicitly designed to run with the coded series of workflows to test different flow and edge cases.

If I face the same issue, I will try tearing down unnecessary tablets in that test and see. Otherwise we may want to enable tests as a separate PR.

@deepthi
Copy link
Member

deepthi commented Jul 22, 2020

According to the actions view, all tests completed and one failed. https://github.com/vitessio/vitess/actions?query=branch%3Arn-vrepl-crosscell-source
It is not reflecting correctly on the PR. I'm attempting to re-run the failed test.

@deepthi
Copy link
Member

deepthi commented Jul 22, 2020

All tests passed including unit_race which had failed on first attempt. PR is not reflecting results from GH actions correctly.

@deepthi deepthi merged commit 4230e00 into vitessio:master Jul 22, 2020
@deepthi deepthi added this to the v7.0 milestone Jul 27, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rohit-nayak-ps @deepthi