Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replica transactions #6244

Merged
merged 33 commits into from
Jun 5, 2020
Merged

Replica transactions #6244

merged 33 commits into from
Jun 5, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented May 29, 2020 •
edited
Loading

Fixes #6166

deepthi and others added 25 commits May 25, 2020 15:18
@deepthi
replica transactions: initial implementation
99faad4 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transactions: do not allow if using discoverygateway
b97066b 
Signed-off-by: deepthi <deepthi@planetscale.com>
@systay @deepthi
replica transactions: fixed endtoend test
65a8a5c 
Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transactions: tabletHealthCheck no longer has a mu
2e647fc 
Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
Cleaned up test
3c14906 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Renamed fake test methods to include legacy
8438053 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Made TabletGateWay use an interface for the HealthCheck
dccd6b6 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Clean up of test
031527c 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
replica transaction: fixed tests
0b7bc39 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi
replica transactions: protect tabletHealthCheck.Conn with mutex
77a274f 
Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
Merge remote-tracking branch 'upstream/master' into ds-replica-transa…
abf30b7 
…ction

Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi
replica transactions: commit and rollback should be executed on the c…
72ae94d 
…orrect tablet

Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
Make tx_engine use read only transactions when in replica mode
be11233 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Test cleanup
c5cffda 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
Update test assertions
ab38d4a 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi
replica transactions: tx_conn.commitNormal should rollback successful…
c14319a 
… shards if a subset fails

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transactions: allow with prepared statements, fix commit2PC
015849a 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transactions: disallow DMLs on non-master tablets
a8915b1 
Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
replica transactions: test cleanup
7900711 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
replica transactions: refactor check so it's done in one place
f13b506 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay
replica-transactions: updated tests to work with the new master checking
e149589 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@deepthi
test framework: rename funcs, replica tablet type should be set
a79abb3 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transaction: test tablet down and up produces correct error a…
bb7ac34 
…nd works

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transactions: move test up one level since it is no longer ju…
bc2d19b 
…st healthcheck

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
add more assertions to commit order tests
8caab43 
Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner May 29, 2020 19:59
@deepthi deepthi requested a review from harshit-gangal May 29, 2020 19:59
@deepthi deepthi mentioned this pull request May 29, 2020
Closed
deepthi and others added 2 commits May 29, 2020 16:14
@deepthi
replica transactions: prepared statement test
935af38 
Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
Merge remote-tracking branch 'upstream/master' into ds-replica-transa…
79e068d 
…ction

Signed-off-by: Andres Taylor <andres@planetscale.com>
deepthi and others added 2 commits June 1, 2020 14:20
@deepthi
fix vtexplain breakage due to replica transaction changes
c123179 
Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
Merge remote-tracking branch 'upstream/master' into ds-replica-transa…
3f85942 
…ction

Signed-off-by: Andres Taylor <andres@planetscale.com>
sougou
sougou reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Got a few questions.

@systay
Address PR reviews
e7887c4 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the ds-replica-transaction branch from 2a7d8e4 to e7887c4 Compare June 3, 2020 15:54
deepthi added 2 commits June 3, 2020 11:15
@deepthi
replica transactions: add TabletAlias to the grpc Request/Response. g…
96d0d0f 
…rpc client ignores the value of the alias in the response for backwards compatibility

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
replica transactions: commitNormal should attempt rollback even if co…
96aad32 
…mmit failed, this will be best effort and any errors are ignored.

Signed-off-by: deepthi <deepthi@planetscale.com>
@systay
Copy link
Collaborator

systay commented Jun 4, 2020

The failing endtoend test is failing on master as well

@systay
Merge remote-tracking branch 'upstream/master' into ds-replica-transa…
a7cb8e2 
…ction

Signed-off-by: Andres Taylor <andres@planetscale.com>
@sougou sougou merged commit 2b071a9 into vitessio:master Jun 5, 2020
@deepthi deepthi mentioned this pull request Jun 25, 2020
Closed
@deepthi deepthi deleted the ds-replica-transaction branch July 6, 2020 19:00
@deepthi deepthi added this to the v7.0 milestone Jul 17, 2020
@ameetkotian ameetkotian mentioned this pull request Aug 20, 2020
Merged
@hallaroo hallaroo mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@sougou sougou sougou approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

RFC: Replica transactions
3 participants
@deepthi @systay @sougou