Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heartbeat: create table only on master with binlog ON, use app_user not dba_user #6053

Merged
merged 1 commit into from
Apr 13, 2020
Merged

heartbeat: create table only on master with binlog ON, use app_user not dba_user #6053

merged 1 commit into from
Apr 13, 2020

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Apr 11, 2020 •
edited
Loading

Fixes #5822, fixes #4071.

cc @acharis @gedgar

Signed-off-by: deepthi deepthi@planetscale.com

@deepthi
heartbeat: create table only on master with binlog ON, use app_user n…
27b3b7b 
…ot dba_user

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi deepthi requested a review from sougou as a code owner April 11, 2020 03:33
sougou
sougou approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@sougou sougou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@morgo morgo merged commit fa58c10 into vitessio:master Apr 13, 2020
@sougou sougou mentioned this pull request Apr 15, 2020
Closed
@deepthi deepthi deleted the ds-heartbeat-fix branch May 14, 2020 16:47
@ajm188 ajm188 mentioned this pull request Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

heartbeat_enable writes to replica and requires dba privs avoid errant gtids from heartbeat
3 participants
@deepthi @sougou @morgo