Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker bootstrap #5999

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 31, 2020

The Dockerfile broke around the time that Python was removed. It is an easy fix, but I'm also removing some Python dependencies that are no longer required.

Signed-off-by: Morgan Tocker tocker@gmail.com

@morgo
Copy link
Contributor Author

morgo commented Mar 31, 2020

From what I can tell, the ruby-* packages were only used by the rpm / deb building script. But we've been building packages using a GitHub action (outside of Docker), so I think it is best to remove the dependency.

I've managed to confirm a Docker bootstrap passed with these edits.

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo force-pushed the morgo-fix-docker-bootstrap branch from 6c12f93 to 6ad0713 Compare March 31, 2020 22:42
@morgo morgo requested a review from sougou as a code owner March 31, 2020 22:42
…bootstrap

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@morgo morgo merged commit fa7bdf0 into vitessio:master Apr 1, 2020
@morgo morgo deleted the morgo-fix-docker-bootstrap branch April 1, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants