Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for vtexplain #4413

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Fix for vtexplain #4413

merged 4 commits into from
Dec 5, 2018

Conversation

rafael
Copy link
Member

@rafael rafael commented Dec 3, 2018

Description

  • This fixes for the most part the issue described in here: https://vitess.slack.com/archives/C0PQY0PTK/p1543558082021800
  • There are still some corner cases where we see this error. We believe this is due to an issue in tabletservers not shutting down mysql conns cleanly (our mysql client library doesn't do a ComQuit clean shutdown sequence).

@rafael
Make sure tabletserver is shutdown before cleaning up DB
9d73c34 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael
Stop server and also close te/messager/watcher
18e1aa1 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael
This actually stops everything we need
40ef7fe 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael
Refactor place where clanup is done so it's clearer
b654418 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner December 3, 2018 19:18
@demmer demmer merged commit 3f5a312 into vitessio:master Dec 5, 2018
frouioui pushed a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
@planetscale-actions-bot @shlomi-noach
[latest-18.0](vitessio#4413): CherryPick(vitessio#15224): Tablet thro…
f75659e 
…ttler: adding more stats (vitessio#4414)

* backport of 4413

* resolved conflict

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot
cherry pick of 15224 (#4413)
1fefdc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demmer demmer demmer approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @demmer