Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtgate: Fix that the tablet type is shown in the "Partitions:" list o… #2097

Conversation

michael-berlin
Copy link
Contributor

…n the status page.

Before, string(i) was shown where i is the index of the array element (e.g. 0, 1 or 2). string(i) for these low i values always returned an empty string because it would be interpreted as an ASCII code and these low values do not map to printable characters.

Other changes:

  • use upper case tablet type string in the ServedFrom output. This is consistent with the "Gateway Status" and "Health Check Cache" output.
  • Fixed output of the ShardingColumnType enum.

…n the status page.

Before, string(i) was shown where i is the index of the array element (e.g. 0, 1 or 2). string(i) for these low i values always returned an empty string because it would be interpreted as an ASCII code and these low values do not map to printable characters.

Other changes:
- use upper case tablet type string in the ServedFrom output. This is consistent with the "Gateway Status" and "Health Check Cache" output.
- Fixed output of the ShardingColumnType enum.
@alainjobart
Copy link
Contributor

alainjobart commented Oct 3, 2016

LGTM

Approved with PullApprove

@michael-berlin michael-berlin merged commit b5862ec into vitessio:master Oct 3, 2016
@michael-berlin michael-berlin deleted the vtgate_status_page_show_type_per_partition branch October 3, 2016 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants